Fix consume flow tests for new DDO structure #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamiehewitt15
left a comment
jamiehewitt15
left a comment
There was a problem hiding this comment.
Let's move this ready for review, so that we can get an approval on it before merging oceanprotocol/ocean-node#774
Ideally, we don't want to merge that PR with the tests running on this branch:
with:
repository: 'oceanprotocol/ocean-cli'
path: 'ocean-cli'
ref: 'fix-tests-for-new-ddo'
Contributor
|
Should we also add some extra systems tests for the new DDO format? I'm not saying that we need to do them here but we could create an issue for it. |
mariacarmina
requested review from
alexcos20,
bogdanfazakas and
paulo-ocean
as code owners
Contributor
Author
Yes we can adapt, let's create an issue for it, but also the main functionality of new ddo should be placed in ocean-node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/oceanprotocol/ocean-node/actions/runs/12978617621/job/36193464270 .
Changes proposed in this PR: